Code review comment for lp:~cyphermox/xchat-gnome/update-to-0.26.2+git
Revision history for this message
| Mathieu Trudel-Lapierre (cyphermox) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> Hey Mathieu, thanks for your nice work there :)
>
> Some little fixes to take into consideration:
>
Hey Didier, thanks for the input.
> * NOCONFIGURE=1 ./autogen.sh; \
> -> you will need automake and such in the builder chroot in that case. I
> would suggest using dh_autoreconf (and build-dep on dh-autoreconf then)
> rather.
Thanks, done.
>
> * debian/control:
> -> all changes aren't listed/explained
I'll assume you meant more "explained", than listed, because I don't see a change I didn't mention. However, I added some more details about the "why" the changes were made.