Code review comment for lp:~cyphermox/xchat-gnome/update-to-0.26.2+git

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Mathieu, thanks for your nice work there :)

Some little fixes to take into consideration:

* NOCONFIGURE=1 ./autogen.sh; \
-> you will need automake and such in the builder chroot in that case. I would suggest using dh_autoreconf (and build-dep on dh-autoreconf then) rather.

* debian/control:
-> all changes aren't listed/explained

review: Needs Fixing

« Back to merge proposal