Code review comment for lp:~cyphermox/ubuntu/natty/lunar-applet/lp708721

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Hi Artur,

Thanks for the quick review!

I addressed most of your concerns:
 - Forwarded is updated in patch tags
 - Bug is forwarded to Debian and the relevant tag was added.

I also changed the target to natty as requested.

However, I did not add the Closes: tag to changelog, because I believe it will be added by the Debian maintainer once a fix is uploaded in Debian -- this will avoid having the entry twice in changelog, plus these entries will likely be lost in a future sync once the bug is corrected in Debian -- not to mention how this would not cause the bug to be closed in the Debian tracker anyway.

What do you think?

« Back to merge proposal