Code review comment for lp:~cyphermox/ubuntu/natty/cnetworkmanager/lp677589
Revision history for this message
| Mathieu Trudel-Lapierre (cyphermox) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I'll respectfully disagree on some points:
- target to Natty; I'm fine with applying this change (and I did), but it's not strictly required. It's also fairly common procedure to submit UNRELEASED changes for sponsoring, then the sponsor will use dch -t or whatnot to release/
- entry format: I think this is to be left to the individual maintainers. There is no guideline or rule made for how a changelog entry should look, and for other networkmanager packages we've been routinely using the "previous" format (the one I initially had in changelog. That said, I don't feel strongly for either way, so I've updated it.
- DEP-3 states: "When Subject is used, it is expected that the long description is outside of the structured fields." which is why I've added a short description on the Subject: line, and a long description outside of structured fields.