Ubuntu
cnetworkmanager package

Code review comment for lp:~cyphermox/ubuntu/natty/cnetworkmanager/lp677589

  1. Natty (11.04)
  2. lp677589
  3. Merge into natty
Revision history for this message
Artur Rona (ari-tczew) wrote :

Please improve debian/changelog entry with following suggestion:

target to natty: s/UNRELEASED/natty

  * debian/patches/nm_0-8-2_dbus_api.patch: Unbreak as much as possible
    of cnetworkmanager to work with NM 0.8.2 and above. Some DBUS API changes broke
    ap listing, connection, etc. Which really should work for the package to be useful.
    (LP: #677589)

update timestamp would be nice.;
add dot at the end of subject tag;
add tag 'Description' before sentence in line 4 (patch), so should look like Description: There has been...

Package built fine.

review: Needs Fixing

« Back to merge proposal