Merge lp:~cyphermox/ubuntu/lucid/wpasupplicant/dbus-pkcs11-eapol into lp:ubuntu/lucid/wpasupplicant

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp:~cyphermox/ubuntu/lucid/wpasupplicant/dbus-pkcs11-eapol
Merge into: lp:ubuntu/lucid/wpasupplicant
Diff against target: 70 lines (+50/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/git_dbus_smartcard_eapol_d719934.patch (+41/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~cyphermox/ubuntu/lucid/wpasupplicant/dbus-pkcs11-eapol
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
Review via email: mp+87780@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-03-07 01:11:22 +0000
3+++ debian/changelog 2012-01-06 16:58:27 +0000
4@@ -1,3 +1,11 @@
5+wpasupplicant (0.6.9-3ubuntu3.1) lucid-proposed; urgency=low
6+
7+ * debian/patches/git_dbus_smartcard_eapol_d719934.patch: cherry-pick a patch
8+ from Git to correctly re-initialize pointers in the WPA state machine to
9+ avoid crashing when smartcard parameters change over DBUS (LP: #528087)
10+
11+ -- Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com> Fri, 06 Jan 2012 11:49:41 -0500
12+
13 wpasupplicant (0.6.9-3ubuntu3) lucid; urgency=low
14
15 * rebuild rest of main for armel armv7/thumb2 optimization;
16
17=== added file 'debian/patches/git_dbus_smartcard_eapol_d719934.patch'
18--- debian/patches/git_dbus_smartcard_eapol_d719934.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/git_dbus_smartcard_eapol_d719934.patch 2012-01-06 16:58:27 +0000
20@@ -0,0 +1,41 @@
21+From d7199342f0633b5ab147dca5b885530fe32ceaeb Mon Sep 17 00:00:00 2001
22+From: David Smith <david.daniel.smith@gmail.com>
23+Date: Wed, 11 Nov 2009 17:46:15 +0200
24+Subject: [PATCH 1/1] Reset EAPOL pointer when handling DBus smartcard parameters
25+
26+Smartcard parameter update via DBus ended up re-initializing the EAPOL
27+state machine without updating the pointer inside WPA state machine.
28+This can trigger a segfault when EAP layer attempts to use the old
29+reference. Fix this by re-initializing the pointer inside WPA state
30+machine.
31+---
32+ wpa_supplicant/ctrl_iface_dbus_handlers.c | 4 ++++
33+ 1 files changed, 4 insertions(+), 0 deletions(-)
34+
35+diff --git a/wpa_supplicant/ctrl_iface_dbus_handlers.c b/wpa_supplicant/ctrl_iface_dbus_handlers.c
36+index 2fd4e23..0e9d4af 100644
37+--- a/wpa_supplicant/ctrl_iface_dbus_handlers.c
38++++ b/wpa_supplicant/ctrl_iface_dbus_handlers.c
39+@@ -27,6 +27,7 @@
40+ #include "wpas_glue.h"
41+ #include "eapol_supp/eapol_supp_sm.h"
42+ #include "wps_supplicant.h"
43++#include "wpa.h"
44+
45+ extern int wpa_debug_level;
46+ extern int wpa_debug_show_keys;
47+@@ -1270,8 +1271,11 @@ DBusMessage * wpas_dbus_iface_set_smartcard_modules(
48+ wpa_s->conf->pkcs11_module_path = pkcs11_module_path;
49+ #endif /* EAP_TLS_OPENSSL */
50+
51++ wpa_sm_set_eapol(wpa_s->wpa, NULL);
52+ eapol_sm_deinit(wpa_s->eapol);
53++ wpa_s->eapol = NULL;
54+ wpa_supplicant_init_eapol(wpa_s);
55++ wpa_sm_set_eapol(wpa_s->wpa, wpa_s->eapol);
56+
57+ return wpas_dbus_new_success_reply(message);
58+
59+--
60+1.7.4-rc1
61+
62
63=== modified file 'debian/patches/series'
64--- debian/patches/series 2010-03-05 12:45:09 +0000
65+++ debian/patches/series 2012-01-06 16:58:27 +0000
66@@ -6,3 +6,4 @@
67 10_multi_driver.patch
68 11_syslog.patch
69 12_no_syslog_flood.patch
70+git_dbus_smartcard_eapol_d719934.patch

Subscribers

People subscribed via source and target branches