Merge lp:~cyphermox/nautilus/lp625696 into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 96
Proposed branch: lp:~cyphermox/nautilus/lp625696
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 60 lines (+37/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/18_preedit_use_imcontext.patch (+27/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~cyphermox/nautilus/lp625696
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Ubuntu Desktop Pending
Review via email: mp+36301@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

That fixes the crash and I don't notice any side effects! Thanks :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-09-13 21:35:33 +0000
3+++ debian/changelog 2010-09-22 13:59:43 +0000
4@@ -1,3 +1,12 @@
5+nautilus (1:2.31.92-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Patch typeahead search in icon/compact view to properly deal with input
8+ method changes (LP: #625696)
9+ - added debian/patches/18_preedit_use_imcontext.patch
10+ - updated debian/patches/series
11+
12+ -- Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com> Wed, 22 Sep 2010 09:17:53 -0400
13+
14 nautilus (1:2.31.92-0ubuntu1) maverick; urgency=low
15
16 * New upstream version:
17
18=== added file 'debian/patches/18_preedit_use_imcontext.patch'
19--- debian/patches/18_preedit_use_imcontext.patch 1970-01-01 00:00:00 +0000
20+++ debian/patches/18_preedit_use_imcontext.patch 2010-09-22 13:59:43 +0000
21@@ -0,0 +1,27 @@
22+From: Fumihito YOSHIDA <hito@ubuntu.com>
23+Subject: Fix crash in preedit_changed handler, where nautilus crashes on
24+ most IM context changes due to the missing GtkIMContext in the signal handler
25+Last-Update: 2010-09-22
26+
27+Index: nautilus/libnautilus-private/nautilus-icon-container.c
28+===================================================================
29+--- nautilus.orig/libnautilus-private/nautilus-icon-container.c 2010-09-22 09:12:48.529747993 -0400
30++++ nautilus/libnautilus-private/nautilus-icon-container.c 2010-09-22 09:14:37.359747997 -0400
31+@@ -4916,7 +4916,7 @@
32+ * callback.
33+ */
34+ static void
35+-nautilus_icon_container_search_preedit_changed (GtkEntry *entry,
36++nautilus_icon_container_search_preedit_changed (GtkIMContext *im_context,
37+ NautilusIconContainer *container)
38+ {
39+ container->details->imcontext_changed = 1;
40+@@ -5274,7 +5274,7 @@
41+ g_signal_connect (container->details->search_entry, "activate",
42+ G_CALLBACK (nautilus_icon_container_search_activate),
43+ container);
44+- g_signal_connect (container->details->search_entry,
45++ g_signal_connect (GTK_ENTRY (container->details->search_entry)->im_context,
46+ "preedit-changed",
47+ G_CALLBACK (nautilus_icon_container_search_preedit_changed),
48+ container);
49
50=== modified file 'debian/patches/series'
51--- debian/patches/series 2010-09-13 21:35:33 +0000
52+++ debian/patches/series 2010-09-22 13:59:43 +0000
53@@ -5,6 +5,7 @@
54 12_list-view_expand.patch
55 15_translations_list_update.patch
56 16_desktop_menu_export.patch
57+18_preedit_use_imcontext.patch
58 80_suppress_umount_in_ltsp.patch
59 82_gnome-app-install.patch
60 83_never_exec_nonexec_launchers.patch

Subscribers

People subscribed via source and target branches

to all changes: