Code review comment for lp:~cyphermox/maas/maas-enlist-wget-not-curl

Revision history for this message
Mike Pontillo (mpontillo) wrote :

I just tested both implementations and confirmed the issue. (the wget implementation, for example, doesn't work with power parameters whose passwords have the '&' character in them).

I noticed another difference as well: the original `curl` implementation helpfully prints the JSON output from the MAAS API call to stdout, whereas the wget version redirects it to /dev/null, leaving the user with no real indication of success or failure. That should be fixed as well before this lands.

« Back to merge proposal