Code review comment for lp:~cyphermox/maas/maas-enlist-wget-not-curl

Revision history for this message
Mike Pontillo (mpontillo) wrote :

In this case it looks like the original curl implementation is more robust, since it URL encodes the parameters properly, whereas the wget implementation will just concatenate them into the URL string.

I would rather split this into enlist_node_wget() and enlist_node_curl() and have a --wget parameter to choose the wget backend if desired, leaving the curl backend the default.

review: Needs Fixing

« Back to merge proposal