Code review comment for lp:~cyphermox/libgrip/inline

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Mathieu, thanks for the merge!

* I would say as for the other MR: did you test that multiarch didn't break the installed version?
* Please remove the undeeded Breaks/Replaces that are not in a supported upgrade path
* -exec rm {} \ can be done with -delete as seb mentionned the other day :)

If you change the two latest and can answer "yes" to the first one, please get it merged :)
Nice work!

review: Approve

« Back to merge proposal