Code review comment for lp:~cyphermox/ido/inline
Revision history for this message
| Didier Roche-Tolomelli (didrocks) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
This looks good to me, nice work :)
However, two comments:
- Why do we override dh_makeshlibs as we have a symbol file? Any particular reason?
- I don't think we should comment the tests right now (or at least, ensure we tackle reenabling it in the next MR). Can you look if we need xvfb or anything similar to make it run? Maybe you can coordinate with Charles on this.