Merge lp:~cyphermox/evolution-indicator/url-source into lp:evolution-indicator

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 80
Proposed branch: lp:~cyphermox/evolution-indicator/url-source
Merge into: lp:evolution-indicator
Diff against target: 50 lines (+9/-5)
1 file modified
src/evolution-indicator.c (+9/-5)
To merge this branch: bzr merge lp:~cyphermox/evolution-indicator/url-source
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+66213@code.launchpad.net

Description of the change

Fix URL retrieval after evo got updated to past 3.0.2. Evo API changes and no longer directly exposes the URL of the account store.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/evolution-indicator.c'
--- src/evolution-indicator.c 2011-05-27 10:57:30 +0000
+++ src/evolution-indicator.c 2011-06-28 22:16:12 +0000
@@ -227,14 +227,18 @@
227void227void
228org_gnome_mail_new_notify (EPlugin *ep, EMEventTargetFolder *t)228org_gnome_mail_new_notify (EPlugin *ep, EMEventTargetFolder *t)
229{229{
230 g_return_if_fail (t != NULL);230 gchar *url;
231
232 g_return_if_fail (t != NULL);
233
234 url = camel_service_get_url (CAMEL_SERVICE (t->store));
231235
232 if (!t->new)236 if (!t->new)
233 return;237 return;
234238
235 if (only_inbox && !(t->is_inbox))239 if (only_inbox && !(t->is_inbox))
236 {240 {
237 g_debug ("EI: %s is not an inbox", t->uri);241 g_debug ("EI: %s is not an inbox", url);
238 return;242 return;
239 }243 }
240244
@@ -246,7 +250,7 @@
246250
247 g_static_mutex_lock (&mlock);251 g_static_mutex_lock (&mlock);
248252
249 g_debug ("EI:mail_new_notify: %s", t->uri);253 g_debug ("EI:mail_new_notify: %s", url);
250254
251 message_count += t->new;255 message_count += t->new;
252 256
@@ -259,7 +263,7 @@
259 {263 {
260 IndicateIndicator *indi = i->data;264 IndicateIndicator *indi = i->data;
261265
262 if (g_strstr_len (t->uri,266 if (g_strstr_len (url,
263 -1,267 -1,
264 indicate_indicator_get_property (indi, "url")))268 indicate_indicator_get_property (indi, "url")))
265 {269 {
@@ -280,7 +284,7 @@
280 }284 }
281 else285 else
282 {286 {
283 g_warning ("EI: Unable to find account that matches %s", t->uri);287 g_warning ("EI: Unable to find account that matches %s", url);
284 }288 }
285 }289 }
286290

Subscribers

People subscribed via source and target branches