Merge lp:~cyphermox/evolution-data-server/lp720434 into lp:~ubuntu-desktop/evolution-data-server/ubuntu

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 83
Proposed branch: lp:~cyphermox/evolution-data-server/lp720434
Merge into: lp:~ubuntu-desktop/evolution-data-server/ubuntu
Diff against target: 55 lines (+13/-8)
2 files modified
debian/changelog (+6/-1)
debian/patches/03-gdata-0.7-port.patch (+7/-7)
To merge this branch: bzr merge lp:~cyphermox/evolution-data-server/lp720434
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+56799@code.launchpad.net

Description of the change

Fixes the "Invalid query" error every time one tries to start using Google contacts.

By my testing contacts are very much usable now, I was able to add various data items to different contacts, delete some, etc.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looks good! approved :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-14 06:10:20 +0000
+++ debian/changelog 2011-04-07 16:15:54 +0000
@@ -1,9 +1,14 @@
1evolution-data-server (2.32.2-0ubuntu2) UNRELEASED; urgency=low1evolution-data-server (2.32.2-0ubuntu2) UNRELEASED; urgency=low
22
3 [ Krzysztof Klimonda ]
3 * debian/control:4 * debian/control:
4 - updated libgtk2.0-dev dependency. 5 - updated libgtk2.0-dev dependency.
56
6 -- Krzysztof Klimonda <kklimonda@ubuntu.com> Mon, 14 Mar 2011 07:08:45 +01007 [ Mathieu Trudel-Lapierre ]
8 * debian/patches/03-gdata-0.7-port.patch: Correct libgdata 0.7 port patch to
9 properly set the updated-min property for Google contacts. (LP: #720434)
10
11 -- Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com> Wed, 06 Apr 2011 16:26:11 -0400
712
8evolution-data-server (2.32.2-0ubuntu1) natty; urgency=low13evolution-data-server (2.32.2-0ubuntu1) natty; urgency=low
914
1015
=== modified file 'debian/patches/03-gdata-0.7-port.patch'
--- debian/patches/03-gdata-0.7-port.patch 2010-12-15 16:51:54 +0000
+++ debian/patches/03-gdata-0.7-port.patch 2011-04-07 16:15:54 +0000
@@ -1,13 +1,13 @@
1Index: evolution-data-server-2.32.1/addressbook/backends/google/e-book-backend-google.c1Index: evolution-data-server-2.32.2/addressbook/backends/google/e-book-backend-google.c
2===================================================================2===================================================================
3--- evolution-data-server-2.32.1.orig/addressbook/backends/google/e-book-backend-google.c 2010-10-29 06:22:59.000000000 -04003--- evolution-data-server-2.32.2.orig/addressbook/backends/google/e-book-backend-google.c 2010-11-22 22:26:37.000000000 -0500
4+++ evolution-data-server-2.32.1/addressbook/backends/google/e-book-backend-google.c 2010-12-14 16:35:31.388384002 -05004+++ evolution-data-server-2.32.2/addressbook/backends/google/e-book-backend-google.c 2011-04-06 16:25:52.028825647 -0400
5@@ -511,7 +511,7 @@5@@ -511,7 +511,7 @@
6 GTimeVal updated;6 GTimeVal updated;
7 7
8 g_assert (g_time_val_from_iso8601 (last_updated, &updated) == TRUE);8 g_assert (g_time_val_from_iso8601 (last_updated, &updated) == TRUE);
9- gdata_query_set_updated_min (query, &updated);9- gdata_query_set_updated_min (query, &updated);
10+ gdata_query_set_updated_min (query, ((long) &updated.tv_sec / 60));10+ gdata_query_set_updated_min (query, updated.tv_sec);
11 gdata_contacts_query_set_show_deleted (GDATA_CONTACTS_QUERY (query), TRUE);11 gdata_contacts_query_set_show_deleted (GDATA_CONTACTS_QUERY (query), TRUE);
12 }12 }
13 13
@@ -24,10 +24,10 @@
24 NULL, &error));24 NULL, &error));
25 g_object_unref (entry);25 g_object_unref (entry);
26 26
27Index: evolution-data-server-2.32.1/configure.ac27Index: evolution-data-server-2.32.2/configure.ac
28===================================================================28===================================================================
29--- evolution-data-server-2.32.1.orig/configure.ac 2010-12-14 16:35:38.008384001 -050029--- evolution-data-server-2.32.2.orig/configure.ac 2010-12-27 08:19:33.000000000 -0500
30+++ evolution-data-server-2.32.1/configure.ac 2010-12-14 16:35:51.328384001 -050030+++ evolution-data-server-2.32.2/configure.ac 2011-04-06 16:25:19.628825650 -0400
31@@ -325,12 +325,6 @@31@@ -325,12 +325,6 @@
32 libsoup-2.4 >= libsoup_minimum_version32 libsoup-2.4 >= libsoup_minimum_version
33 libgdata >= libgdata_minimum_version])33 libgdata >= libgdata_minimum_version])

Subscribers

People subscribed via source and target branches