Code review comment for lp:~cwayne/xpresser/xpresser-double-click

Revision history for this message
Chris Wayne (cwayne) wrote :

Reviewers: mp+85175_code.launchpad.net,

Message:
Please take a look.

Description:
Added double click funcitonality

https://code.launchpad.net/~cwayne18/xpresser/xpresser-double-click/+merge/85175

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5485056/

Affected files:
   M xpresser/xp.py
   M xpresser/xutils.py

Index: xpresser/xp.py
=== <email address hidden> >
<email address hidden>
=== modified file 'xpresser/xp.py'
--- xpresser/xp.py 2010-11-08 14:38:23 +0000
+++ xpresser/xp.py 2011-12-09 18:35:34 +0000
@@ -76,6 +76,16 @@
              xp.right_click(x, y)
          """
          xutils.right_click(*self._compute_focus_point(args))
+
+ def double_click(self, *args):
+ '''Double clicks over the position specified by arguments
+
+ The following examples show valid ways of specifying te position:
+ xp.double_click("image-name")
+ xp.double_click(image_match)
+ xp.double_click(x, y)
+ '''
+ xutils.double_click(*self._compute_focus_point(args))

      def hover(self, *args):
          """Hover over the position specified by the provided arguments.

Index: xpresser/xutils.py
=== <email address hidden> >
<email address hidden>
=== modified file 'xpresser/xutils.py'
--- xpresser/xutils.py 2010-11-04 22:14:59 +0000
+++ xpresser/xutils.py 2011-12-09 18:35:34 +0000
@@ -34,6 +34,9 @@
  def right_click(x, y):
      pyatspi.Registry.generateMouseEvent(x, y, pyatspi.MOUSE_B3C)

+def double_click(x, y):
+ pyatspi.Registry.generateMouseEvent(x, y, pyatspi.MOUSE_B1D)
+
  def hover(x, y):
      pyatspi.Registry.generateMouseEvent(x, y, pyatspi.MOUSE_ABS)

« Back to merge proposal