Do

Code review comment for lp:~cszikszoy/do/config-MA-ext

Revision history for this message
Robert Dyer (psybers) wrote :

All line #s refer to the merge diff.

1. Line 95, too many tabs I believe

2. Line 92, you should lift 'Addin.GetIdName (id)' out of the LINQ statement as it only needs evaluated once (the compiler probably is smart enough to figure this out on its own, but it also makes the code easier to read)

3. Also, can we not just match on the ID? Why are we matching on names?

4. Why are we calling notebook.RemovePage(i) in OnBtnCloseClicked now? Is the window re-used somewhere (that's the only reason I can see for removing the pages, since the Build() will just create a new notebook each time a new Window is created).

review: Needs Fixing

« Back to merge proposal