Do

Code review comment for lp:~cszikszoy/do/config-MA-ext

Revision history for this message
Chris S. (cszikszoy) wrote :

Aside from what Robert already stated, there is a benefit here for plugins that want more than one config page, but only have one ItemSource or Action. A good example of this is the Flickr plugin. This plugin consists of only a single Action, yet an entirely empty ItemSource was also made for the sole purpose of implementing IConfigurable in order to have two config pages.

Also, as you stated, Do.Platform.* can now provide an extension point for configurables. Say we decide to move away from GTK and do everything in an environment-specific gui toolkit. Do.Platform.Windows provides an extension point: Config. Addins can specify what their dependency is, either Platform.Linux, Platform.Windows etc.

« Back to merge proposal