Code review comment for lp:~csurbhi/ubuntu/natty/os-prober/os-prober.fix764893

Revision history for this message
Surbhi Palande (csurbhi) wrote :

Hi Colin,

Thanks a lot for the insightful review. Did not know about the fs-corruption issue before. The reading of the $tmpmnt/@ indeed is a lot more code than mount-bind (or remount) and I decided against it just for the same reason before.

I have uploaded the changes after testing them on kvm. Please do let me know if they look good now.

Regards,
Surbhi.

« Back to merge proposal