Code review comment for lp:~cshorler/ubuntu/lucid/python-qt4/upstream-and-bug-561303

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Christopher! Thanks so much for submitting this for upload to Ubuntu. You have done an outstanding job wit it, despite "not being an Ubuntu user or bzr user".

There are a few little niggles that were missed, because this is a Stable Release Update, but I will handle them and upload. Basically:

1) The target needs to be lucid-proposed, not lucid, so it can go into our proposed updates area for testing.

2) the bug needs a clear test case. I found one in the comments of the bug, and so have added it to the bug report.

3) The changelog moved entries around. Though that was correct, its not necessary (I think bzr merge does this automatically). So I reverted that.

review: Approve

« Back to merge proposal