Code review comment for lp:~cristiklein/notify-osd/multihead-bottompanel

Revision history for this message
Karl Lattimer (karl-qdh) wrote :

I have a few concerns about this patch partly because the conversation with Chow Loong Jin doesn't come to any actual conclusion.

 1, I'm concerned the patch breaks the following specification for spacing; https://wiki.ubuntu.com/NotifyOSD#Outside%20the%20bubble
 2, That in certain monitor configurations e.g. fullscreen application on the screen above the desktop screen and other similar corner cases this patch fails to correctly assign a screen for the notification to be on.
 3, There are commented out pieces of code left in the patch.

« Back to merge proposal