Code review comment for lp:~crichter/openlp/media_rewrite

Revision history for this message
Tim Bentley (trb143) wrote :

162 - Plugins should push stuff in and core save it. Core should not go and grab it. If they are media plugins then we need to new name a plugins will be confussing. It has for me!

No check on inactive plugins. This should be added and removed when plugins are activated / deactivated. Unless covered by above

766 is a python object so you should have get_display_CSS also 864 and 871
862 868 duplicate blank lines
920 MediaManager is python so need _'s in method names
949 # Signals spaced needed. In many places.
977 this is for plugins not core so it necessary change name.

Toolbar you do not need to next / prev slides so these nned to be removed.

1815 should be indented.
1963 why do we need to add extra layer of object?

2275 Line length. No lines over 80 characters
2422 blank line

2582 why remove mediatab

review: Needs Fixing

« Back to merge proposal