Code review comment for ~crass/casper:fix-unsafe-mount-iso-loopback

Revision history for this message
Glenn Washburn (crass) wrote :

In bug #230703 comment #7[1], Collin Watson says in response to a comment about this data loss bug in lupin "yes, it is a real problem elsewhere, and I'm pretty sure there are bugs about it. That doesn't justify introducing the same bug here, in a much more widely used case. Far more people use the Ubuntu live CD than the other cases you mentioned, and it is extremely important that it not trash the system by default."

He goes on to say "Hibernating and booting a live CD is a much more plausible real-world scenario than either hibernating and performing a USB stick installation or hibernating and performing a Wubi installation."

And then "This change should be reverted, and a comment should be added above the code in question to indicate that it must not be modified to include any filesystem type that might be able to mount a journalled filesystem, so that we don't forget this in future."

Seems like he considered this a serious issue over 15 years ago...

[1] https://bugs.launchpad.net/ubuntu/+source/casper/+bug/230703/comments/7

« Back to merge proposal