Code review comment for ~crass/casper:fix-unsafe-mount-iso-loopback

Revision history for this message
Steve Langasek (vorlon) wrote :

Ok looking at that bug report, I see that it says:

> When a hibernated windows partition exists the ntfs3g mounter will refuse to mount the partition in
> read/write mode and returns an error. This will cause the search script to die and the boot process to
> stop, bringing the system to a debugging shell in the initrd.

But it's straightforward to just mount the filesystem read-only instead, and you're using a much bigger hammer here to disallow even ATTEMPTING to mount the filesystem by default. And the net result is not a better user experience for the user vs what is described in that bug report, because you say the ntfs3g filesystem fails to mount and thus blocks the boot - which is the same result as when casper refuses to try to mount it at all.

I see that you point out that casper actually scans filesystems to find the image, so it's not a matter of having wrongly told casper to look at a SPECIFIC device that has a dirty journal. Nevertheless, the bug report does not support the changes proposed here.

« Back to merge proposal