Code review comment for lp:~craighewetson-deactivatedaccount/qbzr/jira_support

Revision history for this message
Alexander Belchenko (bialix) wrote :

NOTE: Please don't mix tabs and spaces (I see some oddness in tests).

I think you don't need plus in regexp of prefix, i.e.

_jira_bug_id_re = lazy_regex.lazy_compile(r'(?:.*/browse/)([A-Z][A-Z0-9_]*-\d+)($)')

that way you require first character always be uppercase letter after that zero or several letters, digits or underscores.

Plus means one or more, IIRC. In that case we don't need plus, really.

review: Needs Fixing

« Back to merge proposal