Code review comment for lp:~cr3/checkbox/multitouch

Revision history for this message
Marc Tardif (cr3) wrote :

After testing on an all-in-one system with a multitouch screen and a mouse, these were the results:

touchpad/singletouch-automated fail
touchpad/multitouch-automated pass
touchpad/multitouch-manual uninitiated
touchscreen/nontouch-automated fail
touchscreen/multitouch-automated pass
touchscreen/multitouch-manual uninitiated

The problem is that both the touchpad and the touchscreen were being filtered as the same device by this command:

  xinput_resource | filter_templates -w 'class=XITouchClass' -w 'touch_mode=dependent' -b 'name=Virtual core pointer'| grep 'name:'

and this command:

  xinput_resource | filter_templates -w 'class=XITouchClass' -w 'touch_mode=direct' -b 'name=Virtual core pointer'| grep 'name:'

The reason is that the whitelist arguments seem to be or'ed instead of and'ed. So, these commands were changed to:

  xinput_resource | filter_templates -w 'class=XITouchClass' | grep -q 'touch_mode: dependent'

and this command respectively:

  xinput_resource | filter_templates -w 'class=XITouchClass' | grep -q 'touch_mode: direct'

Since grep is now used in quiet mode, there's really no reason to blacklist the Virtual core pointer device anymore.

review: Needs Resubmitting

« Back to merge proposal