Merge lp:~cr3/checkbox/key_test_python3 into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 1398
Proposed branch: lp:~cr3/checkbox/key_test_python3
Merge into: lp:checkbox
Diff against target: 38 lines (+2/-4)
2 files modified
debian/control (+1/-1)
scripts/key_test (+1/-3)
To merge this branch: bzr merge lp:~cr3/checkbox/key_test_python3
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Review via email: mp+107623@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

So we're going for 'only works in python3'. That's fine by me, I don't see any reason why we'd want to backport this to any version older than Oneiric anyway.

review: Approve
Revision history for this message
Marc Tardif (cr3) wrote :

For your reassurance, "only works in python3" is the way to move forward that was recommended during python3 related sessions at UDS.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2012-03-07 00:10:02 +0000
+++ debian/control 2012-05-28 13:36:18 +0000
@@ -11,7 +11,7 @@
11Section: python11Section: python
12Architecture: any12Architecture: any
13Depends: ${misc:Depends}, ${python:Depends}, debconf, python-libxml2, udev13Depends: ${misc:Depends}, ${python:Depends}, debconf, python-libxml2, udev
14Recommends: dpkg (>= 1.13), gstreamer0.10-gconf, lsb-release, perl, pm-utils, python-apport, python-apt, python-dateutil, python-gst0.10, python-gtk214Recommends: dpkg (>= 1.13), gstreamer0.10-gconf, lsb-release, perl, pm-utils, python-apport, python-apt, python-dateutil, python-gst0.10, python-gtk2, python3-gi
15Suggests: checkbox-cli | checkbox-gtk, bonnie++, bootchart, bzr, cvs, ethtool, flex, fwts, git-core, hdparm, lshw, make, nmap, obexd-client, python-pexpect, smartmontools, sox, stress, wodim, mesa-utils, wmctrl15Suggests: checkbox-cli | checkbox-gtk, bonnie++, bootchart, bzr, cvs, ethtool, flex, fwts, git-core, hdparm, lshw, make, nmap, obexd-client, python-pexpect, smartmontools, sox, stress, wodim, mesa-utils, wmctrl
16Description: System testing application 16Description: System testing application
17 This project provides an extensible interface for system testing. The17 This project provides an extensible interface for system testing. The
1818
=== modified file 'scripts/key_test'
--- scripts/key_test 2012-05-25 20:21:21 +0000
+++ scripts/key_test 2012-05-28 13:36:18 +0000
@@ -1,4 +1,4 @@
1#!/usr/bin/env python1#!/usr/bin/env python3
2#2#
3# This file is part of Checkbox.3# This file is part of Checkbox.
4#4#
@@ -105,7 +105,6 @@
105 """Parse the characters into a scancode."""105 """Parse the characters into a scancode."""
106 index = 0106 index = 0
107 length = len(characters)107 length = len(characters)
108 characters = map(ord, characters)
109 while index < length:108 while index < length:
110 if (index + 1 < length109 if (index + 1 < length
111 and characters[index] == 0xE0):110 and characters[index] == 0xE0):
@@ -122,7 +121,6 @@
122 """Parse the characters into a keycode."""121 """Parse the characters into a keycode."""
123 index = 0122 index = 0
124 length = len(characters)123 length = len(characters)
125 characters = map(ord, characters)
126 while index < length:124 while index < length:
127 if (index + 2 < length125 if (index + 2 < length
128 and (characters[index] & 0x7f) == 0126 and (characters[index] & 0x7f) == 0

Subscribers

People subscribed via source and target branches