Code review comment for lp:~cr3/checkbox/940627

Revision history for this message
Daniel Manrique (roadmr) wrote :

I think always using checkbox-qt is a reasonable behavior. In addition to what you mention in the last comment, I also checked the behavior for gksu, and if the --description points to a nonexistent file, it simply quotes that name.

So if checkbox-qt.desktop exists, it nicely says "The application named 'System Testing' wants privileges". If it doesn't exist, it says "The application named '/usr/share/applications/checkbox-qt.desktop' wants privileges".

This is potentially not entirely confusing to someone who, as you mention, removed checkbox-qt and ubuntu-desktop by hand.

So my suggestion, sneakily based mostly on *your* arguments, is to just default to checkbox-qt.desktop.

As per our new and fancy review process, since this implies some agreed-upon code changes, I'll set to "Needs Fixing".

review: Needs Fixing

« Back to merge proposal