Merge lp:~cr3/checkbox/729431 into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 902
Proposed branch: lp:~cr3/checkbox/729431
Merge into: lp:checkbox
Diff against target: 26 lines (+5/-1)
2 files modified
debian/changelog (+2/-0)
plugins/manual_test.py (+3/-1)
To merge this branch: bzr merge lp:~cr3/checkbox/729431
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+56355@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good. Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-30 13:30:52 +0000
+++ debian/changelog 2011-04-05 13:35:20 +0000
@@ -1,5 +1,7 @@
1checkbox (0.11.3) natty; urgency=low1checkbox (0.11.3) natty; urgency=low
22
3 * Fixed keyerror when running some manual tests (LP: #729431)
4
3 [Ara Pulido]5 [Ara Pulido]
4 * Improved debconf messages and ordering (LP: #553777)6 * Improved debconf messages and ordering (LP: #553777)
5 * Video bugs should be reported as a display symptom (LP: #744964)7 * Video bugs should be reported as a display symptom (LP: #744964)
68
=== modified file 'plugins/manual_test.py'
--- plugins/manual_test.py 2010-03-07 19:57:57 +0000
+++ plugins/manual_test.py 2011-04-05 13:35:20 +0000
@@ -34,7 +34,9 @@
34 # Avoid modifying the content of test in place34 # Avoid modifying the content of test in place
35 temp = dict(test)35 temp = dict(test)
36 self._manager.reactor.fire("prompt-shell", interface, temp)36 self._manager.reactor.fire("prompt-shell", interface, temp)
37 return (temp["status"], temp["data"], temp["duration"])37 return (temp["status"],
38 temp.get("data", ""),
39 temp.get("duration", 0))
3840
39 interface.show_test(test, runner)41 interface.show_test(test, runner)
40 self._manager.reactor.fire("prompt-test", interface, test)42 self._manager.reactor.fire("prompt-test", interface, test)

Subscribers

People subscribed via source and target branches