Merge lp:~cr3/checkbox/1053126 into lp:checkbox

Proposed by Marc Tardif
Status: Merged
Merged at revision: 1687
Proposed branch: lp:~cr3/checkbox/1053126
Merge into: lp:checkbox
Diff against target: 34 lines (+4/-2)
2 files modified
debian/changelog (+2/-0)
qt/frontend/qtfront.ui (+2/-2)
To merge this branch: bzr merge lp:~cr3/checkbox/1053126
Reviewer Review Type Date Requested Status
Jeff Marcom (community) Approve
Review via email: mp+125354@code.launchpad.net

Description of the change

Make sure to verify this change by building the project in qtcreator. Thanks!

To post a comment you must log in.
Revision history for this message
Jeff Marcom (jeffmarcom) wrote :

Approved, with the following additional change:

- <widget class="QWidget" name="layoutWidget">
+ <widget class="QWidget" name="mainTestLayoutWidget">
                    <property name="geometry">
                     <rect>
                      <x>10</x>
@@ -774,7 +774,7 @@
                     </item>
                    </layout>
                   </widget>
- <widget class="QWidget" name="layoutWidget">
+ <widget class="QWidget" name="testLayoutWidget">

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-09-19 21:25:18 +0000
+++ debian/changelog 2012-09-19 21:50:38 +0000
@@ -66,6 +66,8 @@
66 * patch/0.14.2: Fixed patch to rmtree instead of rmdir scripts directory.66 * patch/0.14.2: Fixed patch to rmtree instead of rmdir scripts directory.
67 * [FEATURE] debian/checkbox.templates, debian/checkbox.config: Added support to67 * [FEATURE] debian/checkbox.templates, debian/checkbox.config: Added support to
68 preseed properties in environment_info plugin.68 preseed properties in environment_info plugin.
69 * [FEATURE] qt/frontend/qtfront.ui: Fixed warnings when building with
70 qtcreator (LP #1053126)
6971
70 [Sean Feole]72 [Sean Feole]
71 * [FEATURE] scripts/battery_test: measures battery capacity before and after73 * [FEATURE] scripts/battery_test: measures battery capacity before and after
7274
=== modified file 'qt/frontend/qtfront.ui'
--- qt/frontend/qtfront.ui 2012-09-05 19:05:01 +0000
+++ qt/frontend/qtfront.ui 2012-09-19 21:50:38 +0000
@@ -56,7 +56,7 @@
56 <attribute name="title">56 <attribute name="title">
57 <string>Tab 1</string>57 <string>Tab 1</string>
58 </attribute>58 </attribute>
59 <layout class="QHBoxLayout" name="horizontalLayout_2">59 <layout class="QHBoxLayout" name="horizontalLayout_Welcome">
60 <property name="spacing">60 <property name="spacing">
61 <number>0</number>61 <number>0</number>
62 </property>62 </property>
@@ -64,7 +64,7 @@
64 <number>0</number>64 <number>0</number>
65 </property>65 </property>
66 <item>66 <item>
67 <layout class="QVBoxLayout" name="verticalLayout_2">67 <layout class="QVBoxLayout" name="verticalLayout_Welcome">
68 <property name="spacing">68 <property name="spacing">
69 <number>0</number>69 <number>0</number>
70 </property>70 </property>

Subscribers

People subscribed via source and target branches