Code review comment for lp:~cprov/squid/snap

Revision history for this message
Robert Collins (lifeless) wrote :

I agree with Alex.

This is no more or less portable a packaging system that BSD ports, RPM specs, debian/rules etc: its packaging system specific. While I think its entirely appropriate for an upstream project that is publishing e.g. debs to have the rules for that in-tree, the Squid project is not currently publishing snaps for any plaform (and given they are currently Ubuntu-only, that seems unlikely).

Given Canonical is building snappy, has motivation to create and keep the packaging metadata up to date, and (so far at least) noone in squid core is engaged with that, I recommend keeping the snap ruleset in Canonical/Ubuntu's repository as is done for debian/rules.

Note too that the license is incorrect if these *were* to be in squid itself.

« Back to merge proposal