Code review comment for lp:~cprov/squid/snap

Revision history for this message
Celso Providelo (cprov) wrote :

Alex,

Thanks for the quick response on this.

IMHO, having snapcraft.yaml upstream is actually the best way to keep it from bit-rotting, mainly because it will be visible and owned by everyone actually working on upstream changes. With the advantage of hooking effective CI mechanisms to quickly build (verify) and ship changes quickly, like in https://code.launchpad.net/~cprov/+snap/squid-tip (LP snap *auto*build).

I think it sets the right sense of shared ownership and also provides a very short-pipeline for testing and distributing improvements. While a separate (overlay) branch would take many additional hops and coordination to go from fix-landed to fix-distributed to affected people (the traditional distance between upstream & distributions).

Let me know what you think while I implement your suggestions to make the snap files intervention clearer (boilerplate template, more explicit directly structure, computing a suitable configuration file)

« Back to merge proposal