Code review comment for lp:~cprov/launchpad/bug-391810-ppa-build-deps

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

This branch fixes two trivial UI bugs:

https://bugs.edge.launchpad.net/soyuz/+bug/391810
https://bugs.edge.launchpad.net/soyuz/+bug/399090

Both related with the logic used to present or ommit the PPA 'Build dependencies' section.

Now, we won't present empty sections if the user cannot change it and also allow owners to set dependencies before uploading sources.

== Tests ==

./bin/test -vv -t xx-edit-dependencies.txt

== Demo and Q/A ==

1. As no-priv, access https://launchpad.dev/~cprov/+archive/ppa and you won't see the 'Build dependencies' section.

2. As no-priv, access https://launchpad.dev/~no-priv/+archive/ppa and you will be able to set new dependencies even if the PPA is empty

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
 lib/lp/soyuz/stories/ppa/xx-edit-dependencies.txt
 lib/lp/soyuz/templates/archive-index.pt
 lib/lp/soyuz/browser/archive.py
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqJoLMACgkQ7KBXuXyZSjBJegCgnJwJ8V7HRg/qYt5G78XWkT2B
I5QAn0rLjxiyKON5oHE78eM+gPpKwSPc
=rBaW
-----END PGP SIGNATURE-----