Code review comment for lp:~cprov/core-image-watcher/proper-hostname

Revision history for this message
Evan (ev) wrote :

I think the rationale for this should be documented in the code, but it otherwise looks good. Celso explained on IRC the 64 character limit for hostnames and how this lets us avoid a truncated or "ubuntu" hostname in the logs.

review: Approve

« Back to merge proposal