Code review comment for lp:~cprov/core-image-watcher/lint

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

My vote is not to merge this. As shown in the diff, pylint doesn't understand some pretty straight-forward things, and forces us to either make our code less clear, or litter linter disabling comments everywhere.

If silly errors are landing in trunk, let's make sure we do a better job of reviewing MPs, writing tests, and/or manually testing our code (as appropriate to the situation).

review: Needs Fixing

« Back to merge proposal