Code review comment for lp:~cprov/britney/testclient-api

Revision history for this message
Celso Providelo (cprov) wrote :

Psivaa,

Thanks for the review.

Regarding config-changes, they will be only necessary when we do integration tests (which I've mentioned are missing, on purpose, from this MP).
On point 2) I don't get the registry duplication, it's impossible, since it's a dictionary, perhaps you mean re-announcement ?
On point 3) take a look at the corresponding test, it may clarify things about cleanup() effects.
On message ack-ing, you are right it was missing in the collect() action, fixed.

[]

« Back to merge proposal