Code review comment for lp:~cprov/adt-cloud-worker/log-cleanup

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

<thomi> cprov: ok, only thing is, best practise is to do: logger.info("%s", var) not logger.info("%s" % (var)) or logger.info("{}".format(var))
<cprov> thomi: I noticed in your MPs, let me fix mine
<thomi> cprov: also, in my MPs I set 'requests' to WARNING
<thomi> best make them all the same I guess
<thomi> cprov: otherwise, looks good

Looks good - suggest you fix the above two issues.

review: Approve

« Back to merge proposal