Merge lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos into lp:ubuntu-desktop-accomplishments

[Charles Profitt]

[Rafał Cieślak (rafalcieslak256)]

Thanks for this MP, Charles.
Although the script looks perfect, the documentation is far too brief. Would you mind expanding it a bit, explaining that images are usually kept in their directory, and maybe a note on how to do this? Note that this accomplishment documentation if for newbies, so although it seems obvious, it may be good to explain it at least a bit.
Also, your .accomplishment files does not contain 'collection = ubuntu-community' line, which is necessary.

I have also a tip for you: there is no need to copy your accomplishment to pl and bn directories - if you use the 0.2 daemon (available and almost stable in daily builds PPA), it will use the file from en directory, if there is no equivalent in a localized dir - so it saves some efforts (especially in UCA, where we have already ~30 localized directories) :)
Thanks again for your awesome work!

review: Needs Fixing

[lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos]

17. By Charles Profitt <email address hidden> on 2012-06-10

changed accomplishment file

18. By Charles Profitt <email address hidden> on 2012-06-10

added more description to photos description

[Charles Profitt (cprofitt)]

Added a bit more, but not sure if it is enough.

Charles

On Sun, 2012-06-10 at 11:56 +0000, Rafal Cieślak wrote:
> Review: Needs Fixing
>
> Thanks for this MP, Charles.
> Although the script looks perfect, the documentation is far too brief. Would you mind expanding it a bit, explaining that images are usually kept in their directory, and maybe a note on how to do this? Note that this accomplishment documentation if for newbies, so although it seems obvious, it may be good to explain it at least a bit.
> Also, your .accomplishment files does not contain 'collection = ubuntu-community' line, which is necessary.
>
> I have also a tip for you: there is no need to copy your accomplishment to pl and bn directories - if you use the 0.2 daemon (available and almost stable in daily builds PPA), it will use the file from en directory, if there is no equivalent in a localized dir - so it saves some efforts (especially in UCA, where we have already ~30 localized directories) :)
> Thanks again for your awesome work!

[Rafał Cieślak (rafalcieslak256)]

This is not satisfying, but let's consider this a bug, so that others may expand it.
Thanks again Charles for this accom, I have just merged it in! And sorry for the delay.

review: Approve

=== modified file 'CATEGORIES'
--- CATEGORIES	2012-05-19 18:08:54 +0000
+++ CATEGORIES	2012-06-10 19:57:18 +0000
@@ -4,3 +4,4 @@
 
 Audio and Video
 Games
+Multimedia

=== added file 'accomplishments/ubuntu-desktop/en/multimedia/multimedia-added-photos.accomplishment'
--- accomplishments/ubuntu-desktop/en/multimedia/multimedia-added-photos.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-desktop/en/multimedia/multimedia-added-photos.accomplishment	2012-06-10 19:57:18 +0000
@@ -0,0 +1,9 @@
+[accomplishment]
+title = Added Photos
+description = You have added photos to your computer
+category = Multimedia
+icon = default.png
+author = Charles Profitt <[e-mail]>
+collection = ubuntu-desktop
+summary = Ubuntu has many great applications to help you edit and manage your photos, but the first step is adding photos to your computer. When you add images to your <i>pictures folder</i> you will earn this accomplishment.
+

=== added file 'scripts/ubuntu-desktop/multimedia/multimedia-added-photos.py'
--- scripts/ubuntu-desktop/multimedia/multimedia-added-photos.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-desktop/multimedia/multimedia-added-photos.py	2012-06-10 19:57:18 +0000
@@ -0,0 +1,39 @@
+#!/usr/bin/python
+import commands, sys, os
+homeDir = os.getenv("HOME")
+path = os.path.join(homeDir,'.config/user-dirs.dirs') 
+result = open(path, "r")
+content = result.readline()
+while (content != "" ):
+	content.replace( "\n", "" )
+	content = result.readline()
+	startStr = content[0:16]
+	if startStr == 'XDG_PICTURES_DIR':
+		photosDir = content
+		print photosDir
+
+# recursive function to go through sub-directories
+def test_for_images(directory):
+    dirList = os.listdir(directory)
+    for fname in dirList:
+        filepath = os.path.join(directory, fname)
+        if os.path.isdir(filepath):
+            test_for_images(filepath)
+        else:
+            filetype = commands.getstatusoutput('file -b "' +filepath + '"')
+            if "image" in filetype[1]:
+                # image file present
+                sys.exit(0)
+                
+
+# removes extra characters around directory
+photosDir = photosDir[24:]
+photosDir = photosDir[:-2]
+
+photos = os.path.join(homeDir, photosDir)
+test_for_images(photos)
+
+
+    
+#user has no images
+sys.exit(1)
\ No newline at end of file