Code review comment for lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Thanks for this MP, Charles.
Although the script looks perfect, the documentation is far too brief. Would you mind expanding it a bit, explaining that images are usually kept in their directory, and maybe a note on how to do this? Note that this accomplishment documentation if for newbies, so although it seems obvious, it may be good to explain it at least a bit.
Also, your .accomplishment files does not contain 'collection = ubuntu-community' line, which is necessary.

I have also a tip for you: there is no need to copy your accomplishment to pl and bn directories - if you use the 0.2 daemon (available and almost stable in daily builds PPA), it will use the file from en directory, if there is no equivalent in a localized dir - so it saves some efforts (especially in UCA, where we have already ~30 localized directories) :)
Thanks again for your awesome work!

review: Needs Fixing

« Back to merge proposal