Orange Box

Code review comment for lp:~cpe-sa/orange-box/staging

staging
Merge into trunk

Revision history for this message

mahmoh (mahmoh) wrote on 2015-07-23:

On 07/23/2015 11:14 AM, Brad wrote:
>> I see Brad change the all behavior instead of fixing bugs . can't
>> afford the time to play that game.. refer to Brad fro now on..
>> Changing behavior /doc and way of operating when seeing a bug is a
>> receipt for never releasing/delivering ..
> I have no clue what that means Nicolas. It does not translate very well. Yes I did have to revert some changes that you made because they were breaking the install. I'd be more than happy to help find solutions, but I don't have time to not have a working package. Please review the revision history and you'll see that they were merely commented out and can be re-added once they've been tested by multiple people.

I think what Nicolas means is, for example, instead of documenting a
"reboot" in the manual to fix a problem in the package/scripts we should
be fixing/adjusting the package/scripts to solve the problem instead and
if possible.

I understand and appreciate your deadline of getting a working package
for tomorrow & next week but I also understand and agree with Nicolas'
frustration that it doesn't excuse us from properly fixing problems.

My suggestion at this point is get a working package for tomorrow's
deadline but schedule a mini-sprint ASAP so we can work this out. We
could use next week's team time to discuss this if anyone's interested?

>
>>
>>
>>
>>
>> On Thu, Jul 23, 2015 at 1:30 PM, Zhanglei Mao
>> <email address hidden> wrote:
>>> My orange-box-add-virtual-nodes script was enclosed
>>>
>>> On Thu, Jul 23, 2015 at 7:21 PM, Nicolas Thomas <
>>> <email address hidden>> wrote:
>>>
>>>> Brad this should not append with my last modification merged on the code???
>>>>
>>>> Mao please send orange-box-add-virtual-nodes script ..
>>>>
>>>> On Thu, Jul 23, 2015 at 1:06 PM, Zhanglei Mao
>>>> <email address hidden> wrote:
>>>>> hi Brad,
>>>>>
>>>>> I test it again. It is still stop at the errors as yesterday. I follow
>>>> the manual, only exception are area use local Hongkong and I use Wifi for
>>>> internet.
>>>>>
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> + sudo -u maas tee -a /var/lib/maas/.ssh/known_hosts
>>>>> + sudo -u maas ssh-keyscan 172.27.8.1
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> + sudo -u maas virsh -c qemu+ssh://ubuntu@172.27.8.1/system list
>>>>> error: failed to connect to the hypervisor
>>>>> error: Cannot recv data: Permission denied (publickey).: Connection
>>>> reset by peer
>>>>> + sed -i '/ maas@/d' /home/ubuntu/.ssh/authorized_keys
>>>>> sed: can't read /home/ubuntu/.ssh/authorized_keys: No such file or
>>>> directory
>>>>> dpkg: error processing package orange-box (--configure):
>>>>> subprocess installed post-installation script returned error exit
>>>> status 2
>>>>> Setting up libwww-perl (6.05-2) ...
>>>>> Setting up libxml-parser-perl (2.41-1build3) ...
>>>>> Setting up libsoap-lite-perl (1.09-1) ...
>>>>> Setting up libxmlrpc-lite-perl (0.717-1) ...
>>>>> Processing triggers for libc-bin (2.19-0ubuntu6.6) ...
>>>>> Processing triggers for initramfs-tools (0.103ubuntu4.2) ...
>>>>> update-initramfs: Generating /boot/initrd.img-3.16.0-44-generic
>>>>> Errors were encountered while processing:
>>>>> orange-box
>>>>> E: Sub-process /usr/bin/dpkg returned an error code (1)
>>>>> ubuntu@OrangeBox8:~$
>>>>>
>>>>> thanks,
>>>>> Mao
>>>>> --
>>>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>>>> You proposed lp:~cpe-sa/orange-box/staging for merging.
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nicolas Thomas
>>>> http://insights.ubuntu.com/?p=889
>>>> EMEA Solution Architect Canonical
>>>> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9
>>>>
>>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>>> Your team Orange Box is requested to review the proposed merge of
>>>> lp:~cpe-sa/orange-box/staging into lp:orange-box.
>>>>
>>>
>>>
>>>
>>> --
>>> Zhanglei Mao
>>> Solutions Architect, Sales and Business Development
>>> Canonical Group Ltd.
>>> <email address hidden>
>>> +86-13625010929 (m)
>>> +852-6700 6026 (m)
>>> www.ubuntu.com
>>> www.canonical.com
>>>
>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>> You proposed lp:~cpe-sa/orange-box/staging for merging.
>>
>>
>>
>> --
>> Best Regards,
>> Nicolas Thomas
>> http://insights.ubuntu.com/?p=889
>> EMEA Solution Architect Canonical
>> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

My suggestion at this point is get a working package for tomorrow's
deadline but schedule a mini-sprint ASAP so we can work this out.  We
could use next week's team time to discuss this if anyone's interested?

> 
>>
>>
>>
>>
>> On Thu, Jul 23, 2015 at 1:30 PM, Zhanglei Mao
>> <zhanglei.mao@canonical.com> wrote:
>>> My orange-box-add-virtual-nodes script was enclosed
>>>
>>> On Thu, Jul 23, 2015 at 7:21 PM, Nicolas Thomas <
>>> nicolas.thomas@canonical.com> wrote:
>>>
>>>> Brad this should not append with my last modification merged on the code???
>>>>
>>>> Mao please send orange-box-add-virtual-nodes script ..
>>>>
>>>> On Thu, Jul 23, 2015 at 1:06 PM, Zhanglei Mao
>>>> <zhanglei.mao@canonical.com> wrote:
>>>>> hi Brad,
>>>>>
>>>>> I test it again. It is still stop at the errors as yesterday. I follow
>>>> the manual, only exception are area use local Hongkong and I use Wifi for
>>>> internet.
>>>>>
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> + sudo -u maas tee -a /var/lib/maas/.ssh/known_hosts
>>>>> + sudo -u maas ssh-keyscan 172.27.8.1
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> # 172.27.8.1 SSH-2.0-OpenSSH_6.6.1p1 Ubuntu-2ubuntu2
>>>>> + sudo -u maas virsh -c qemu+ssh://ubuntu@172.27.8.1/system list
>>>>> error: failed to connect to the hypervisor
>>>>> error: Cannot recv data: Permission denied (publickey).: Connection
>>>> reset by peer
>>>>> + sed -i '/ maas@/d' /home/ubuntu/.ssh/authorized_keys
>>>>> sed: can't read /home/ubuntu/.ssh/authorized_keys: No such file or
>>>> directory
>>>>> dpkg: error processing package orange-box (--configure):
>>>>>  subprocess installed post-installation script returned error exit
>>>> status 2
>>>>> Setting up libwww-perl (6.05-2) ...
>>>>> Setting up libxml-parser-perl (2.41-1build3) ...
>>>>> Setting up libsoap-lite-perl (1.09-1) ...
>>>>> Setting up libxmlrpc-lite-perl (0.717-1) ...
>>>>> Processing triggers for libc-bin (2.19-0ubuntu6.6) ...
>>>>> Processing triggers for initramfs-tools (0.103ubuntu4.2) ...
>>>>> update-initramfs: Generating /boot/initrd.img-3.16.0-44-generic
>>>>> Errors were encountered while processing:
>>>>>  orange-box
>>>>> E: Sub-process /usr/bin/dpkg returned an error code (1)
>>>>> ubuntu@OrangeBox8:~$
>>>>>
>>>>> thanks,
>>>>> Mao
>>>>> --
>>>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>>>> You proposed lp:~cpe-sa/orange-box/staging for merging.
>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>>        Nicolas Thomas
>>>> http://insights.ubuntu.com/?p=889
>>>> EMEA Solution Architect              Canonical
>>>> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9
>>>>
>>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>>> Your team Orange Box is requested to review the proposed merge of
>>>> lp:~cpe-sa/orange-box/staging into lp:orange-box.
>>>>
>>>
>>>
>>>
>>> --
>>> Zhanglei Mao
>>> Solutions Architect, Sales and Business Development
>>> Canonical Group Ltd.
>>> zhanglei.mao@canonical.com
>>> +86-13625010929 (m)
>>> +852-6700 6026 (m)
>>> www.ubuntu.com
>>> www.canonical.com
>>>
>>> https://code.launchpad.net/~cpe-sa/orange-box/staging/+merge/265504
>>> You proposed lp:~cpe-sa/orange-box/staging for merging.
>>
>>
>>
>> --
>> Best Regards,
>>        Nicolas Thomas
>> http://insights.ubuntu.com/?p=889
>> EMEA Solution Architect              Canonical
>> GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

« Back to merge proposal