Merge lp:~costales/unav/same-btns-place into lp:unav

Proposed by costales
Status: Merged
Approved by: costales
Approved revision: 211
Merged at revision: 210
Proposed branch: lp:~costales/unav/same-btns-place
Merge into: lp:unav
Diff against target: 76 lines (+35/-9)
2 files modified
manifest.json (+1/-1)
qml/Main.qml (+34/-8)
To merge this branch: bzr merge lp:~costales/unav/same-btns-place
Reviewer Review Type Date Requested Status
costales Pending
Review via email: mp+345198@code.launchpad.net

Commit message

Same buttons all time

To post a comment you must log in.
lp:~costales/unav/same-btns-place updated
211. By costales

Updated version to 1.1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'manifest.json'
--- manifest.json 2018-03-24 18:18:57 +0000
+++ manifest.json 2018-05-16 19:40:38 +0000
@@ -12,5 +12,5 @@
12 "maintainer": "Marcos Costales <costales.marcos@gmail.com>",12 "maintainer": "Marcos Costales <costales.marcos@gmail.com>",
13 "name": "navigator.costales",13 "name": "navigator.costales",
14 "title": "uNav",14 "title": "uNav",
15 "version": "1.0"15 "version": "1.1"
16}16}
1717
=== modified file 'qml/Main.qml'
--- qml/Main.qml 2018-03-24 18:18:57 +0000
+++ qml/Main.qml 2018-05-16 19:40:38 +0000
@@ -61,7 +61,7 @@
61 width: unavWindow.width + units.gu(0.1) //TODO: Investigate why this is needed61 width: unavWindow.width + units.gu(0.1) //TODO: Investigate why this is needed
62 height: unavWindow.height + units.gu(0.1) //TODO: Investigate why this is needed62 height: unavWindow.height + units.gu(0.1) //TODO: Investigate why this is needed
6363
64 property string applicationVersion: "1.0"64 property string applicationVersion: "1.1"
65 property string mapUrl: "../nav/index.html"65 property string mapUrl: "../nav/index.html"
66 property string appUA: "Mozilla/5.0 (Linux; Android 5.0; Nexus 5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.102 Mobile Safari/537.36 Project uNav"66 property string appUA: "Mozilla/5.0 (Linux; Android 5.0; Nexus 5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.102 Mobile Safari/537.36 Project uNav"
6767
@@ -930,7 +930,7 @@
930 }930 }
931931
932 Row {932 Row {
933 spacing: units.gu(2)933 spacing: units.gu(0.5)
934 anchors.horizontalCenter: parent.horizontalCenter934 anchors.horizontalCenter: parent.horizontalCenter
935935
936 GridIconDelegate {936 GridIconDelegate {
@@ -949,12 +949,38 @@
949 }949 }
950950
951 GridIconDelegate {951 GridIconDelegate {
952 icon.name: "call-start"952 icon.name: mainPageStack.favPopup ? "starred" : "non-starred"
953 icon.height: units.gu(3)953 icon.height: units.gu(3)
954 highlightSize: units.gu(-1)954 highlightSize: units.gu(-1)
955 visible: goThereActionPopover.phone !== ""955 onClicked: {
956 onClicked: {956 mainPageStack.favPopup = !mainPageStack.favPopup;
957 Qt.openUrlExternally("tel:///" + QmlJs.parse_poi_phone(goThereActionPopover.phone))957 mainPageStack.showSideBar();
958 var incubator = mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("SearchPage.qml"), {favLat: mainPageStack.clickedLat, favLng: mainPageStack.clickedLng, favName: ""});
959 incubator.onStatusChanged = function(status) {
960 if (status === Component.Ready) {
961 incubator.object.addFavorite();
962 }
963 }
964 }
965 }
966
967 GridIconDelegate {
968 icon.name: "location"
969 icon.height: units.gu(3)
970 highlightSize: units.gu(-1)
971 onClicked: {
972 mainPageStack.showSideBar();
973 mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("PoiPage.qml"), {"lat": mainPageStack.clickedLat, "lng": mainPageStack.clickedLng});
974 }
975 }
976
977 GridIconDelegate {
978 icon.name: "share"
979 icon.height: units.gu(3)
980 highlightSize: units.gu(-1)
981 onClicked: {
982 mainPageStack.showSideBar();
983 mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("Share.qml"), {"lat": mainPageStack.clickedLat, "lon": mainPageStack.clickedLng, "isParentPage": true});
958 }984 }
959 }985 }
960986

Subscribers

People subscribed via source and target branches