Merge lp:~costales/unav/same-btns-place into lp:unav

Proposed by costales
Status: Merged
Approved by: costales
Approved revision: 211
Merged at revision: 210
Proposed branch: lp:~costales/unav/same-btns-place
Merge into: lp:unav
Diff against target: 76 lines (+35/-9)
2 files modified
manifest.json (+1/-1)
qml/Main.qml (+34/-8)
To merge this branch: bzr merge lp:~costales/unav/same-btns-place
Reviewer Review Type Date Requested Status
costales Pending
Review via email: mp+345198@code.launchpad.net

Commit message

Same buttons all time

To post a comment you must log in.
lp:~costales/unav/same-btns-place updated
211. By costales

Updated version to 1.1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'manifest.json'
2--- manifest.json 2018-03-24 18:18:57 +0000
3+++ manifest.json 2018-05-16 19:40:38 +0000
4@@ -12,5 +12,5 @@
5 "maintainer": "Marcos Costales <costales.marcos@gmail.com>",
6 "name": "navigator.costales",
7 "title": "uNav",
8- "version": "1.0"
9+ "version": "1.1"
10 }
11
12=== modified file 'qml/Main.qml'
13--- qml/Main.qml 2018-03-24 18:18:57 +0000
14+++ qml/Main.qml 2018-05-16 19:40:38 +0000
15@@ -61,7 +61,7 @@
16 width: unavWindow.width + units.gu(0.1) //TODO: Investigate why this is needed
17 height: unavWindow.height + units.gu(0.1) //TODO: Investigate why this is needed
18
19- property string applicationVersion: "1.0"
20+ property string applicationVersion: "1.1"
21 property string mapUrl: "../nav/index.html"
22 property string appUA: "Mozilla/5.0 (Linux; Android 5.0; Nexus 5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.102 Mobile Safari/537.36 Project uNav"
23
24@@ -930,7 +930,7 @@
25 }
26
27 Row {
28- spacing: units.gu(2)
29+ spacing: units.gu(0.5)
30 anchors.horizontalCenter: parent.horizontalCenter
31
32 GridIconDelegate {
33@@ -949,12 +949,38 @@
34 }
35
36 GridIconDelegate {
37- icon.name: "call-start"
38- icon.height: units.gu(3)
39- highlightSize: units.gu(-1)
40- visible: goThereActionPopover.phone !== ""
41- onClicked: {
42- Qt.openUrlExternally("tel:///" + QmlJs.parse_poi_phone(goThereActionPopover.phone))
43+ icon.name: mainPageStack.favPopup ? "starred" : "non-starred"
44+ icon.height: units.gu(3)
45+ highlightSize: units.gu(-1)
46+ onClicked: {
47+ mainPageStack.favPopup = !mainPageStack.favPopup;
48+ mainPageStack.showSideBar();
49+ var incubator = mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("SearchPage.qml"), {favLat: mainPageStack.clickedLat, favLng: mainPageStack.clickedLng, favName: ""});
50+ incubator.onStatusChanged = function(status) {
51+ if (status === Component.Ready) {
52+ incubator.object.addFavorite();
53+ }
54+ }
55+ }
56+ }
57+
58+ GridIconDelegate {
59+ icon.name: "location"
60+ icon.height: units.gu(3)
61+ highlightSize: units.gu(-1)
62+ onClicked: {
63+ mainPageStack.showSideBar();
64+ mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("PoiPage.qml"), {"lat": mainPageStack.clickedLat, "lng": mainPageStack.clickedLng});
65+ }
66+ }
67+
68+ GridIconDelegate {
69+ icon.name: "share"
70+ icon.height: units.gu(3)
71+ highlightSize: units.gu(-1)
72+ onClicked: {
73+ mainPageStack.showSideBar();
74+ mainPageStack.addPageToNextColumn(mainPageStack.primaryPage, Qt.resolvedUrl("Share.qml"), {"lat": mainPageStack.clickedLat, "lon": mainPageStack.clickedLng, "isParentPage": true});
75 }
76 }
77

Subscribers

People subscribed via source and target branches