Code review comment for lp:~costales/unav/load-main-after-tuto

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

I was able to reproduce a case where the map is visible while viewing the nearby location list. Please apply the following patch to fix the bug,

=== modified file 'qml/Main.qml'
--- qml/Main.qml 2016-04-02 15:01:08 +0000
+++ qml/Main.qml 2016-04-02 15:50:21 +0000
@@ -80,7 +80,7 @@
     PageStack {
         id: mainPageStack

- Component.onCompleted: navApp.settings.showTuto ? mainPageStack.push(Qt.resolvedUrl("tuto/WelcomeWizard.qml")) : push(navigationPage)
+ Component.onCompleted: if (navApp.settings.showTuto) mainPageStack.push(Qt.resolvedUrl("tuto/WelcomeWizard.qml"))// : push(navigationPage)

         property string currentLat: "null"
         property string currentLng: "null"
@@ -111,7 +111,7 @@
         Page {
             id: navigationPage

- visible: mainPageStack.depth !== 1
+ visible: mainPageStack.depth === 0

             property bool buttonsEnabled: false

review: Needs Fixing

« Back to merge proposal