Merge lp:~costales/unav/0.65-parse-pois-url into lp:unav

Proposed by costales
Status: Merged
Merged at revision: 152
Proposed branch: lp:~costales/unav/0.65-parse-pois-url
Merge into: lp:unav
Diff against target: 56 lines (+14/-3)
3 files modified
qml/PoiDetailsPage.qml (+2/-2)
qml/PoiListPage.qml (+1/-1)
qml/js/utils.js (+11/-0)
To merge this branch: bzr merge lp:~costales/unav/0.65-parse-pois-url
Reviewer Review Type Date Requested Status
uNav developers Pending
Review via email: mp+314264@code.launchpad.net

Description of the change

Add http:// in the beggining if the POI hasn't that in the URL, for launch externally in the browser.

To post a comment you must log in.
153. By costales

http or https

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/PoiDetailsPage.qml'
--- qml/PoiDetailsPage.qml 2016-07-15 13:11:01 +0000
+++ qml/PoiDetailsPage.qml 2017-01-09 13:31:35 +0000
@@ -68,7 +68,7 @@
68 cuisine.title = poiDetailsModel.get(0).cuisine68 cuisine.title = poiDetailsModel.get(0).cuisine
69 phone.title = poiDetailsModel.get(0).phone69 phone.title = poiDetailsModel.get(0).phone
70 openingHours.title = poiDetailsModel.get(0).opening_hours70 openingHours.title = poiDetailsModel.get(0).opening_hours
71 website.title = poiDetailsModel.get(0).website71 website.title = QmlJs.parse_poi_url(poiDetailsModel.get(0).website)
72 internet.title = poiDetailsModel.get(0).internet_access72 internet.title = poiDetailsModel.get(0).internet_access
73 wheelchair.title = poiDetailsModel.get(0).wheelchair73 wheelchair.title = poiDetailsModel.get(0).wheelchair
74 lat = parseFloat(mainPageStack.clickedLat)74 lat = parseFloat(mainPageStack.clickedLat)
@@ -125,7 +125,7 @@
125 poiActionButtonModel.append({mode: "CALL", iconName: "call-start"})125 poiActionButtonModel.append({mode: "CALL", iconName: "call-start"})
126 }126 }
127127
128 if (website.title && website.title.substring(0, 4) === "http") {128 if (website.title) {
129 poiActionButtonModel.append({mode: "WEB", iconName: "stock_website"})129 poiActionButtonModel.append({mode: "WEB", iconName: "stock_website"})
130 }130 }
131 }131 }
132132
=== modified file 'qml/PoiListPage.qml'
--- qml/PoiListPage.qml 2016-07-15 14:30:09 +0000
+++ qml/PoiListPage.qml 2017-01-09 13:31:35 +0000
@@ -222,7 +222,7 @@
222 "name": poiXmlModel.get(i).name.split(',')[0],222 "name": poiXmlModel.get(i).name.split(',')[0],
223 "description": poiXmlModel.get(i).description,223 "description": poiXmlModel.get(i).description,
224 "phone": poiXmlModel.get(i).phone,224 "phone": poiXmlModel.get(i).phone,
225 "website": poiXmlModel.get(i).website,225 "website": QmlJs.parse_poi_url(poiXmlModel.get(i).website),
226 // "cuisine": poiXmlModel.get(i).cuisine,226 // "cuisine": poiXmlModel.get(i).cuisine,
227 "wheelchair": poiXmlModel.get(i).wheelchair,227 "wheelchair": poiXmlModel.get(i).wheelchair,
228 "openinghours": poiXmlModel.get(i).openinghours,228 "openinghours": poiXmlModel.get(i).openinghours,
229229
=== modified file 'qml/js/utils.js'
--- qml/js/utils.js 2016-08-28 07:13:49 +0000
+++ qml/js/utils.js 2017-01-09 13:31:35 +0000
@@ -91,6 +91,17 @@
91}91}
9292
93/**93/**
94* Function parse_poi_url(poi_website): Return string
95* url: POI's URL
96**/
97function parse_poi_url(poi_website) {
98 if (poi_website.substring(0, 8) === "https://" || poi_website.substring(0, 7) === "http://")
99 return poi_website;
100 else
101 return "http://" + poi_website;
102}
103
104/**
94* Function is_url_dispatcher(url): Return boolean105* Function is_url_dispatcher(url): Return boolean
95* url: URL calling uNav106* url: URL calling uNav
96**/107**/

Subscribers

People subscribed via source and target branches