Code review comment for lp:~cosmos-door/ubuntu-keyboard/japanese-keyboard-rebooted

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Great, thanks, one last little thing I spotted, the backspace icon is offset slightly, this actually looks like a bug in the leftSide/rightSide handling for action keys, so for now I'd suggest you just set the width of that key to "panel.keyWidth". Then as a separate task I'll fix the action key icon positioning at a later date and also update all the existing layouts to use leftSide/rightSide for shift and backspace (which they don't currently do).

review: Needs Fixing

« Back to merge proposal