I'll preface this by saying that I'm sick, and my brain isn't working as well as it usually does, so if any of this doesn't make sense, there's a very real chance it's my fault - please feel free to ask any clarifying questions if that's the case.
The code is mostly good, but:
There are a few places that are missing implementation.
I've made a few suggestions throughout the code.
I haven't yet run the coverage metrics - at this stage you should be hitting 100% coverage, or very close to it.
I suggest you implement the missing pieces, so this can be deployed with the rest of the CI engine, and get reviews from the rest of the CI team.
Hi Corey,
I'll preface this by saying that I'm sick, and my brain isn't working as well as it usually does, so if any of this doesn't make sense, there's a very real chance it's my fault - please feel free to ask any clarifying questions if that's the case.
The code is mostly good, but:
There are a few places that are missing implementation.
I've made a few suggestions throughout the code.
I haven't yet run the coverage metrics - at this stage you should be hitting 100% coverage, or very close to it.
I suggest you implement the missing pieces, so this can be deployed with the rest of the CI engine, and get reviews from the rest of the CI team.
Cheers,