Re-reading with a fresh mind, the diff for the events is really:
25 + # disabling native events (use synthesized events instead).
26 + # synthesize events do user emulation via Javascript instead
27 + # of natively. Native keyboard events on Linux break too often
28 + # in Firefox version upgrades.
29 + # see: https://code.google.com/p/selenium/wiki/NativeEventsOnLinux
30 + profile.native_events_enabled = False
The rest is just cosmetic but makes the review harder :-(
It would be better if you split such cleanups out of the real MP IMHO.
Moreover, splitted lines are a pain in tracebacks since python always report
the last line a single ')' in your case. Are you sure it's worth the trouble ?
Re-reading with a fresh mind, the diff for the events is really:
25 + # disabling native events (use synthesized events instead). /code.google. com/p/selenium/ wiki/NativeEven tsOnLinux native_ events_ enabled = False
26 + # synthesize events do user emulation via Javascript instead
27 + # of natively. Native keyboard events on Linux break too often
28 + # in Firefox version upgrades.
29 + # see: https:/
30 + profile.
The rest is just cosmetic but makes the review harder :-(
It would be better if you split such cleanups out of the real MP IMHO.
Moreover, splitted lines are a pain in tracebacks since python always report
the last line a single ')' in your case. Are you sure it's worth the trouble ?