Code review comment for lp:~coreygoldberg/autopilot/tox-and-packaging

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks for the setup.py and the sorted() fixes!

18 +recursive-include debian changelog

Upstream releases generally shouldn't ship packaging information, so debian/ should not be included. But if you do it, why only debian/changelog? Most upstream projects these days don't ship a changelog as you can always get it from VCS, or they autogenerate it from "bzr log" or similar.

64 +commands =
65 + autopilot run autopilot.tests.unit

That runs only the unit tests; could we make this a bit more clever to run the full test suite if there's a $DISPLAY? When porting to py3 I found that a lot of issues only turn up with the integration tests.

review: Needs Fixing

« Back to merge proposal