Merge lp:~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2 into lp:ubuntu/utopic-proposed/python-eventlet

Proposed by Corey Bryant
Status: Merged
Approved by: Brian Murray
Approved revision: 26
Merged at revision: 26
Proposed branch: lp:~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2
Merge into: lp:ubuntu/utopic-proposed/python-eventlet
Diff against target: 114 lines (+53/-20)
3 files modified
debian/changelog (+7/-0)
debian/patches/sslwrap.diff (+25/-12)
eventlet/green/ssl.py (+21/-8)
To merge this branch: bzr merge lp:~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+250455@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This was already uploaded.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-02-09 13:31:20 +0000
+++ debian/changelog 2015-02-20 15:05:36 +0000
@@ -1,3 +1,10 @@
1python-eventlet (0.13.0-1ubuntu3.2) UNRELEASED; urgency=medium
2
3 * debian/patches/sslwrap.diff: Fall back to old behavior if SSLContext
4 not available (LP: #1423675).
5
6 -- Corey Bryant <corey.bryant@canonical.com> Fri, 20 Feb 2015 09:42:26 -0500
7
1python-eventlet (0.13.0-1ubuntu3.1) utopic; urgency=medium8python-eventlet (0.13.0-1ubuntu3.1) utopic; urgency=medium
29
3 * debian/patches/socket-timeout.patch: Cherry-pick patch to provide10 * debian/patches/socket-timeout.patch: Cherry-pick patch to provide
411
=== modified file 'debian/patches/sslwrap.diff'
--- debian/patches/sslwrap.diff 2014-10-08 16:22:45 +0000
+++ debian/patches/sslwrap.diff 2015-02-20 15:05:36 +0000
@@ -1,8 +1,6 @@
1Index: b/eventlet/green/ssl.py
2===================================================================
3--- a/eventlet/green/ssl.py1--- a/eventlet/green/ssl.py
4+++ b/eventlet/green/ssl.py2+++ b/eventlet/green/ssl.py
5@@ -238,14 +238,14 @@ class GreenSSLSocket(__ssl.SSLSocket):3@@ -238,17 +238,30 @@
6 if self._sslobj:4 if self._sslobj:
7 raise ValueError("attempt to connect already-connected SSLSocket!")5 raise ValueError("attempt to connect already-connected SSLSocket!")
8 self._socket_connect(addr)6 self._socket_connect(addr)
@@ -10,18 +8,33 @@
10- self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,8- self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
11- self.cert_reqs, self.ssl_version,9- self.cert_reqs, self.ssl_version,
12- self.ca_certs, self.ciphers)10- self.ca_certs, self.ciphers)
13- else:11+ try:
12+ ctx = SSLContext(self.ssl_version)
13+ except:
14+ if has_ciphers:
15+ self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
16+ self.cert_reqs, self.ssl_version,
17+ self.ca_certs, self.ciphers)
18+ else:
19+ self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
20+ self.cert_reqs, self.ssl_version,
21+ self.ca_certs)
22 else:
14- self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,23- self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
15- self.cert_reqs, self.ssl_version,24- self.cert_reqs, self.ssl_version,
16- self.ca_certs)25- self.ca_certs)
17+ ctx = SSLContext(self.ssl_version)26+ if self.keyfile or self.certfile:
18+ if self.keyfile or self.certfile:27+ ctx.load_cert_chain(self.certfile, self.keyfile)
19+ ctx.load_cert_chain(self.certfile, self.keyfile)28+ if self.ca_certs:
20+ if self.ca_certs:29+ ctx.load_verify_locations(self.ca_certs)
21+ ctx.load_verify_locations(self.ca_certs)30+ if has_ciphers and self.ciphers:
22+ if has_ciphers and self.ciphers:31+ ctx.set_ciphers(self.ciphers)
23+ ctx.set_ciphers(self.ciphers)32+ self._sslobj = ctx._wrap_socket(self._sock, server_side=False)
24+ self._sslobj = ctx._wrap_socket(self._sock, server_side=False)33+
25 if self.do_handshake_on_connect:34 if self.do_handshake_on_connect:
26 self.do_handshake()35 self.do_handshake()
27 36
37+
38 def accept(self):
39 """Accepts a new connection from a remote client, and returns
40 a tuple containing that new connection wrapped with a server-side
2841
=== modified file 'eventlet/green/ssl.py'
--- eventlet/green/ssl.py 2014-10-08 16:22:45 +0000
+++ eventlet/green/ssl.py 2015-02-20 15:05:36 +0000
@@ -238,17 +238,30 @@
238 if self._sslobj:238 if self._sslobj:
239 raise ValueError("attempt to connect already-connected SSLSocket!")239 raise ValueError("attempt to connect already-connected SSLSocket!")
240 self._socket_connect(addr)240 self._socket_connect(addr)
241 ctx = SSLContext(self.ssl_version)241 try:
242 if self.keyfile or self.certfile:242 ctx = SSLContext(self.ssl_version)
243 ctx.load_cert_chain(self.certfile, self.keyfile)243 except:
244 if self.ca_certs:244 if has_ciphers:
245 ctx.load_verify_locations(self.ca_certs)245 self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
246 if has_ciphers and self.ciphers:246 self.cert_reqs, self.ssl_version,
247 ctx.set_ciphers(self.ciphers)247 self.ca_certs, self.ciphers)
248 self._sslobj = ctx._wrap_socket(self._sock, server_side=False)248 else:
249 self._sslobj = _ssl.sslwrap(self._sock, False, self.keyfile, self.certfile,
250 self.cert_reqs, self.ssl_version,
251 self.ca_certs)
252 else:
253 if self.keyfile or self.certfile:
254 ctx.load_cert_chain(self.certfile, self.keyfile)
255 if self.ca_certs:
256 ctx.load_verify_locations(self.ca_certs)
257 if has_ciphers and self.ciphers:
258 ctx.set_ciphers(self.ciphers)
259 self._sslobj = ctx._wrap_socket(self._sock, server_side=False)
260
249 if self.do_handshake_on_connect:261 if self.do_handshake_on_connect:
250 self.do_handshake()262 self.do_handshake()
251263
264
252 def accept(self):265 def accept(self):
253 """Accepts a new connection from a remote client, and returns266 """Accepts a new connection from a remote client, and returns
254 a tuple containing that new connection wrapped with a server-side267 a tuple containing that new connection wrapped with a server-side

Subscribers

People subscribed via source and target branches

to all changes: