Merge ~corey.bryant/lpci:main into lpci:main

[Corey Bryant]

[Jürgen Gmach (jugmac00)]

Thanks for your contribution!

Could you please add an entry in the NEWS.rst?

Also, `bases.BuilddBaseAlias.DEVEL` was only introduced in craft-providers 1.8.1, but our `requirements.in` specify 1.8.0 as minimum version. Could you please update the minimum required version and the comment?

I do not think we need to apply `tox -e pip-compile` now, as version 1.8.1 was used in the requirements.txt anyway - but we (Launchapd devs) should update the dependencies soon.

I do feel a bit uneasy about adding code without tests, but that is the way we did before for adding new series/versions.

A very simple test that verifies that the key is present in `SERIES_TO_BUILDD_IMAGE_ALIAS` and that it maps to the correct image looks like it would not help too much, but at least it guarantees that we do not remove a series by mistake.

Do you want to add such a test? Do not worry if not, then I think I will add one for all series.

[Corey Bryant (corey.bryant)]

Thanks for the review! I have changes but I force pushed them and they're not showing up here so I think I'll resubmit the proposal.

[Corey Bryant (corey.bryant)]

This is ready for re-review. Thanks again.

[Jürgen Gmach (jugmac00)]

Thanks!

As we have no merge-bot active here, I think I need to merge this manually.

review: Approve

[Jürgen Gmach (jugmac00)]

> I have changes but I force pushed them and they're not showing up here so I think I'll resubmit the proposal.

That would indicate an issue with the diff mechanism. I will try to look into that later.

[Jürgen Gmach (jugmac00)]

And FWIW, following semantic versioning a new feature would properly need a bump of the minor version part, but on the one hand we were not very passionate about that in the past, and I can do that when I cut a new release.

[Jürgen Gmach (jugmac00)]

This is live now! Thanks again for your contribution.

[Corey Bryant (corey.bryant)]

Tested and works! Thanks! \o/

diff --git a/NEWS.rst b/NEWS.rst
index 34f9f96..b6e37c7 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -2,6 +2,11 @@
 Version history
 ===============
 
+0.1.3 (unreleased)
+==================
+
+- Add support for non-LTS devel release, which is currently mantic.
+
 0.1.2 (2023-05-02)
 ==================
 
diff --git a/lpci/providers/_buildd.py b/lpci/providers/_buildd.py
index 62c5546..88f5e19 100644
--- a/lpci/providers/_buildd.py
+++ b/lpci/providers/_buildd.py
@@ -20,6 +20,7 @@ SERIES_TO_BUILDD_IMAGE_ALIAS = {
     "jammy": bases.BuilddBaseAlias.JAMMY,
     "kinetic": bases.BuilddBaseAlias.KINETIC,
     "lunar": bases.BuilddBaseAlias.LUNAR,
+    "devel": bases.BuilddBaseAlias.DEVEL,
 }
 
 
diff --git a/lpci/providers/tests/test_buildd.py b/lpci/providers/tests/test_buildd.py
index ea007ef..47d4ea8 100644
--- a/lpci/providers/tests/test_buildd.py
+++ b/lpci/providers/tests/test_buildd.py
@@ -15,3 +15,18 @@ class TestLPCIBuilddBaseConfiguration(TestCase):
             "foo" == LPCIBuilddBaseConfiguration(
                 alias=BuilddBaseAlias.FOCAL,
             )
+
+    def test_series_to_buildd_image_alias(self):
+        alias_mapping = {
+            "16.04": BuilddBaseAlias.XENIAL.value,
+            "18.04": BuilddBaseAlias.BIONIC.value,
+            "20.04": BuilddBaseAlias.FOCAL.value,
+            "22.04": BuilddBaseAlias.JAMMY.value,
+            "22.10": BuilddBaseAlias.KINETIC.value,
+            "23.04": BuilddBaseAlias.LUNAR.value,
+            "devel": BuilddBaseAlias.DEVEL.value,
+        }
+        for k, v in alias_mapping.items():
+            self.assertEqual(k, v)
+
+        self.assertEqual(len(BuilddBaseAlias), len(alias_mapping))
diff --git a/requirements.in b/requirements.in
index 4679cf3..9f747f4 100644
--- a/requirements.in
+++ b/requirements.in
@@ -1,5 +1,5 @@
 craft-cli
-craft-providers>=1.8.0  # 1.8.0 added support of non-LTS releases
+craft-providers>=1.8.1  # 1.8.1 added support of bases.BuilddBaseAlias.DEVEL
 launchpadlib[keyring]
 pydantic
 PyYAML