Merge ~corey.bryant/lpci:main into lpci:main

[Corey Bryant]

[Jürgen Gmach (jugmac00)]

Thanks for your contribution!

Could you please add an entry in the NEWS.rst?

Also, `bases.BuilddBaseAlias.DEVEL` was only introduced in craft-providers 1.8.1, but our `requirements.in` specify 1.8.0 as minimum version. Could you please update the minimum required version and the comment?

I do not think we need to apply `tox -e pip-compile` now, as version 1.8.1 was used in the requirements.txt anyway - but we (Launchapd devs) should update the dependencies soon.

I do feel a bit uneasy about adding code without tests, but that is the way we did before for adding new series/versions.

A very simple test that verifies that the key is present in `SERIES_TO_BUILDD_IMAGE_ALIAS` and that it maps to the correct image looks like it would not help too much, but at least it guarantees that we do not remove a series by mistake.

Do you want to add such a test? Do not worry if not, then I think I will add one for all series.

[Corey Bryant (corey.bryant)]

Thanks for the review! I have changes but I force pushed them and they're not showing up here so I think I'll resubmit the proposal.

Unmerged commits

ae41a09... by Corey Bryant on 2023-05-22

Add suport for current development release

The current development release (mantic) is defined as
ubuntu.BuilddBaseAlias.DEVEL in craft-providers.

	test:0 (build)
	build:0 (build)

1 → 2 of 2 results

First • Previous • Next • Last

diff --git a/lpci/providers/_buildd.py b/lpci/providers/_buildd.py
index 62c5546..88f5e19 100644
--- a/lpci/providers/_buildd.py
+++ b/lpci/providers/_buildd.py
@@ -20,6 +20,7 @@ SERIES_TO_BUILDD_IMAGE_ALIAS = {
     "jammy": bases.BuilddBaseAlias.JAMMY,
     "kinetic": bases.BuilddBaseAlias.KINETIC,
     "lunar": bases.BuilddBaseAlias.LUNAR,
+    "devel": bases.BuilddBaseAlias.DEVEL,
 }