Merge lp:~corey.bryant/charms/trusty/swift-proxy/use-stable into lp:~openstack-charmers-archive/charms/trusty/swift-proxy/trunk

Proposed by Corey Bryant
Status: Merged
Merged at revision: 68
Proposed branch: lp:~corey.bryant/charms/trusty/swift-proxy/use-stable
Merge into: lp:~openstack-charmers-archive/charms/trusty/swift-proxy/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
tests/basic_deployment.py (+1/-1)
To merge this branch: bzr merge lp:~corey.bryant/charms/trusty/swift-proxy/use-stable
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+239469@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #812 trusty-swift-proxy for corey.bryant mp239469
    LINT OK: believed to pass, but you should confirm results

LINT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_lint_check/make-lint.812:
W: config.yaml: option keystone-auth-host does not have the keys: default
W: config.yaml: option ssl_cert does not have the keys: default
W: config.yaml: option os-public-network does not have the keys: default
W: config.yaml: option keystone-admin-password does not have the keys: default

Full lint output: http://paste.ubuntu.com/8707217/
Build: http://10.98.191.181:8080/job/charm_lint_check/812/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #620 trusty-swift-proxy for corey.bryant mp239469
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 4 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.620:
----------------------------------------------------------------------
Ran 5 tests in 0.177s

OK

Full unit output: http://paste.ubuntu.com/8707218/
Build: http://10.98.191.181:8080/job/charm_unit_test/620/

Revision history for this message
Liam Young (gnuoy) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py 2014-10-06 21:35:47 +0000
+++ tests/basic_deployment.py 2014-10-23 20:13:24 +0000
@@ -20,7 +20,7 @@
20class SwiftProxyBasicDeployment(OpenStackAmuletDeployment):20class SwiftProxyBasicDeployment(OpenStackAmuletDeployment):
21 """Amulet tests on a basic swift-proxy deployment."""21 """Amulet tests on a basic swift-proxy deployment."""
2222
23 def __init__(self, series, openstack=None, source=None, stable=False):23 def __init__(self, series, openstack=None, source=None, stable=True):
24 """Deploy the entire test environment."""24 """Deploy the entire test environment."""
25 super(SwiftProxyBasicDeployment, self).__init__(series, openstack,25 super(SwiftProxyBasicDeployment, self).__init__(series, openstack,
26 source, stable)26 source, stable)

Subscribers

People subscribed via source and target branches